Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpacked symfony/serializer-pack dependency declaration #187

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Unpacked symfony/serializer-pack dependency declaration #187

merged 1 commit into from
Nov 7, 2024
+3 −1

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Nov 7, 2024

🎫 Issue N/A

Description:

symfony/serializer-pack should never be used as a 3rd party dependency. It should be unpacked to provide proper semver versioning handling.

For QA:

Documentation:

@adamwojs adamwojs merged commit fa2bfcb into 4.6 Nov 7, 2024
9 checks passed
@adamwojs adamwojs deleted the fix-serializer-pack branch November 7, 2024 12:51
Steveb-p added a commit that referenced this pull request Nov 13, 2024
@Steveb-p
Unpacked symfony/serializer-pack dependency declaration (#187)
95e702d 
(cherry picked from commit fa2bfcb)
@Steveb-p Steveb-p mentioned this pull request Nov 13, 2024
Merged
@mrk-te
Copy link

mrk-te commented Dec 12, 2024

Hello,
symfony/serializer-pack also requires

"phpdocumentor/reflection-docblock": "*",
"phpstan/phpdoc-parser": "*",

Updating to the latest 4.6 or 3.3 version will break usage of the serializer when typing with PHPDoc is required (\App\Model\Hello[])

This change isn't mentionned on any CHANGELOG either on ibexa/oss or ibexa/headless, etc.

@Steveb-p
Copy link
Contributor Author

Steveb-p commented Dec 12, 2024 •
edited
Loading

@mnocon can we add this somewhere in the upgrade doc?

Sorry if this happened to you @mrk-te. Ibexa itself is not making use of phpdoc for serialization, and the pack itself would usually be "unpacked" by Symfony flex into a specific version of above dependencies (which was not happening for installations, as this would be a 3rd party dependency for you). PHPStan 2.0 released a new version of phpdoc-parser which would break majority of installations, and we had to take the change from this PR regardless - and unpack metapackages in general.

See symfony/symfony#58796 for direct issue.

@mnocon mnocon mentioned this pull request Dec 13, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@tischsoic tischsoic tischsoic approved these changes

@ciastektk ciastektk ciastektk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @mrk-te @adamwojs @ciastektk @tischsoic @konradoboza